8000 Fix app hang when importing empty Apple Health data by jdisho · Pull Request #105 · StanfordBDHG/LLMonFHIR · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix app hang when importing empty Apple Health data #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Fix app hang when importing empty Apple Health data #105

merged 1 commit into from
May 28, 2025

Conversation

jdisho
Copy link
Member
@jdisho jdisho commented May 28, 2025

Fix app hang when importing empty Apple Health data

Resolving #104

♻️ Current situation & Problem

This bug happens when Apple Health has no health records. When the app gets health records, it waits up to 10 seconds between each new record. If no new records appear for 10 seconds, the app assumes all records have been added and stops waiting.

⚙️ Release Notes

Set isWaiting to false when there are no health records.

📚 Documentation

N/A

✅ Testing

Manually tested

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@jdisho jdisho self-assigned this May 28, 2025
@jdisho jdisho added the bug Something isn't working label May 28, 2025
@codecov Codecov
Copy link
codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.95%. Comparing base (3b25a72) to head (13bc27f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   22.95%   22.95%           
=======================================
  Files          57       57           
  Lines         632      632           
=======================================
  Hits          145      145           
  Misses        487      487
Files with missing lines Coverage Δ
LLMonFHIR/LLMonFHIRStandard.swift 36.37% <ø> (ø)
LLMonFHIR/ResourceView.swift 85.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b25a72...13bc27f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PSchmiedmayer PSchmiedmayer mentioned this pull request May 28, 2025
Closed
1 task
@jdisho jdisho merged commit 189abac into main May 28, 2025
9 checks passed
< 7905 /div>
@jdisho jdisho deleted the fix-loading-state branch May 28, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSchmiedmayer PSchmiedmayer PSchmiedmayer approved these changes

@lukaskollmer lukaskollmer Awaiting requested review from lukaskollmer

Assignees

@jdisho jdisho

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdisho @PSchmiedmayer
0