Local network access authorization for SpeziLLMFog #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 43.49% 43.49%
=======================================
Files 67 67
Lines 476 476
=======================================
Hits 207 207
Misses 269 269
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces local network access authorization for SpeziLLMFog by adding the onboarding view for fog node discovery and updating related documentation and tests. Key changes include:
- A new LLMFogDiscoveryAuthorizationView and its supporting requester and error handling components.
- Updates in onboarding flows and adjustments in conditional compilation for simulator vs. non-simulator behavior.
- Documentation updates to guide developers on setting up Info.plist entries for local network access.
Reviewed Changes
Copilot reviewed 27 out of 30 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Tests/UITests/TestApp/LLMFog/Onboarding/* | Added onboarding flows for local network access authorization |
| Sources/SpeziLLMLocal/* | Updated conditional compilation for simulator and non-simulator setups |
| Sources/SpeziLLMFog/DisoveryAuthorization/* | New components to request and handle local network authorization |
| README.md | Documentation updates guiding Info.plist configuration for Bonjour discovery |
Files not reviewed (3)
- Sources/SpeziLLMFog/Resources/Localizable.xcstrings: Language not supported
- Tests/UITests/TestApp/Info.plist: Language not supported
- Tests/UITests/TestApp/Info.plist.license: Language not supported
Comments suppressed due to low confidence (1)
Sources/SpeziLLMFog/DisoveryAuthorization/LLMFogDiscoveryAuthoriationView+Requester.swift:1
- The file name appears to have a typo. Consider renaming 'LLMFogDiscoveryAuthoriationView+Requester.swift' to 'LLMFogDiscoveryAuthorizationView+Requester.swift' for consistency.
LLMFogDiscoveryAuthoriationView+Requester.swift
PSchmiedmayer
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local network access authorization for SpeziLLMFog
♻️ Current situation & Problem
Since iOS 18, Bonjour mDNS service discovery for http and https requires users to grant access to the local network.
Right now, the OS popup is triggered upon the first chat message that is dispatched to a fog node in the network, which fails as the authorization is not immediately granted.
⚙️ Release Notes
LLMFogDiscoveryAuthorizationView📚 Documentation
Added in-line documentation for all added components.
✅ Testing
Very hard to test in CI, tested manually on device.
📝 Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: