8000 [Enhancement] change a few metrics fe leader awareness by kevincai · Pull Request #59883 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Enhancement] change a few metrics fe leader awareness #59883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[Enhancement] change a few metrics fe leader awareness #59883

merged 1 commit into from
Jun 17, 2025

Conversation

kevincai
Copy link
Contributor
@kevincai kevincai commented Jun 13, 2025 •
edited
Loading
  • add label is_leader={"true"|"false"} for those metrics that distinguish between leader and follower

Why I'm doing:

What I'm doing:

Fixes #59887

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@kevincai kevincai requested a review from a team as a code owner June 13, 2025 06:36
@kevincai kevincai changed the title [Enhancement] change a few metrics be leader awareness [Enhancement] change a few metrics fe leader awareness Jun 13, 2025
wyb
wyb reviewed Jun 13, 2025
View reviewed changes
@kevincai kevincai force-pushed the enhance/leader-aware-metric branch from ed35ddb to d6a2984 Compare June 13, 2025 09:23
@kevincai kevincai force-pushed the enhance/leader-aware-metric branch from d6a2984 to 4b61474 Compare June 14, 2025 13:05
chaoyli
chaoyli reviewed Jun 16, 2025
View reviewed changes
chaoyli
chaoyli reviewed Jun 16, 2025
View reviewed changes
fe/fe-core/src/main/java/com/starrocks/common/FeConstants.java Outdated
@@ -126,6 +126,9 @@ public class FeConstants {
public static final String DOCUMENT_ALTER_ROUTINE_LOAD =
"https://docs.starrocks.io/docs/sql-reference/sql-statements/data-manipulation/ALTER_ROUTINE_LOAD";

// Historic reason naming as "is_master" rather than "is_leader"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't meet the requirement of the customers. They want to get the consistent metrics between FE leader and FE followers.

  1. In current situation, I think we should forward to the leader to get the metrics.
  2. In final, we should sync the metrics between FE leader and followers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a matter of fact how the system is designed, not how the system is required by the customer.

@kevincai kevincai force-pushed the enhance/leader-aware-metric branch from 4b61474 to a3cc92b Compare June 16, 2025 02:04
@kevincai
[Enhancement] change a few metrics be leader awareness
d08ca96 
* add label `is_master={"true"|"false"}` for those metrics that
  distinguish between leader and follower

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
@kevincai kevincai force-pushed the enhance/leader-aware-metric branch from a3cc92b to d08ca96 Compare June 16, 2025 02:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 20 / 20 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/metric/MetricRepo.java 7 7 100.00% []
🔵 com/starrocks/metric/LeaderAwareGaugeMetricLong.java 3 3 100.00% []
🔵 com/starrocks/metric/LeaderAwareGaugeMetric.java 10 10 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@kevincai kevincai merged commit bf269c8 into StarRocks:main Jun 17, 2025
56 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@kevincai @mergify
[Enhancement] change a few metrics fe leader awareness (#59883)
7f6a6c7 
Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
(cherry picked from commit bf269c8)
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@kevincai @mergify
[Enhancement] change a few metrics fe leader awareness (#59883)
48503d2 
Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
(cherry picked from commit bf269c8)
This was referenced Jun 17, 2025
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @kevincai
[Enhancement] change a few metrics fe leader awareness (backport #59883…
df693cb 
…) (#59964)

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @kevincai
[Enhancement] change a few metrics fe leader awareness (backport #59883…
2b99230 
…) (#59965)

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Co-authored-by: Kevin Cai <caixiaohua@starrocks.com>
@kevincai kevincai mentioned this pull request Jun 18, 2025
Merged
22 tasks
AntiTopQuark pushed a commit to AntiTopQuark/starrocks that referenced this pull request Jun 19, 2025
@kevincai @AntiTopQuark
[Enhancement] change a few metrics fe leader awareness (StarRocks#59883)
5ed02a8 
Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
dengliu pushed a commit to dengliu/starrocks that referenced this pull request Jun 20, 2025
6D40
@kevincai @dengliu
[Enhancement] change a few metrics fe leader awareness (StarRocks#59883)
67a86e8 
Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaoyli chaoyli chaoyli left review comments

@wyb wyb wyb approved these changes

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

Assignees

@kevincai kevincai

Labels
3.4-merged 3.5-merged behavior_changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Metric] FE metrics include is_leader label if the metric is only meaningful on leader FE
4 participants
@kevincai @wyb @chaoyli @alvin-celerdata
0