8000 [BugFix] StreamLoad not working for URL encoded chinese characters (backport #59722) by mergify[bot] · Pull Request #59831 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] StreamLoad not working for URL encoded chinese characters (backport #59722) #59831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2025
Merged

[BugFix] StreamLoad not working for URL encoded chinese characters (backport #59722) #59831

merged 2 commits into from
Jun 20, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 11, 2025 •
edited by wanpengfei-git
Loading

RestBaseAction.java redirectTo() incorrectly processes the table name, should use resultUriObj.toASCIIString() instead of resultUriObj.toString()

Fixes #59721

curl -v -k --location-trusted -uroot -H "label:table1" -H "column_separator:," -T data.csv http://127.0.0.1:8030/api/mydb/testStreamLoad%E6%A1%8C/_stream_load
image

image

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR wil 8000 l result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
    • 3.2
    • 3.1
This is an automatic backport of pull request #59722 done by [Mergify](https://mergify.com).

@rohitrs1983 @mergify
[BugFix] StreamLoad not working for URL encoded chinese characters (#…
fde5b82 
…59722)

RestBaseAction.java redirectTo() incorrectly processes the table name, should use resultUriObj.toASCIIString() instead of resultUriObj.toString()

Fixes #59721

curl -v -k --location-trusted -uroot -H "label:table1" -H "column_separator:," -T data.csv http://127.0.0.1:8030/api/mydb/testStreamLoad%E6%A1%8C/_stream_load

Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
(cherry picked from commit 7a664b7)

# Conflicts:
#	be/test/CMakeLists.txt
#	be/test/http/stream_load_test.cpp
@mergify mergify bot added the conflicts label Jun 11, 2025
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 11, 2025

Cherry-pick of 7a664b7 has failed:

On branch mergify/bp/branch-3.3/pr-59722
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 7a664b7e7a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/http/action/stream_load.cpp
	modified:   be/src/util/url_coding.cpp
	modified:   be/src/util/url_coding.h
	new file:   be/test/util/url_coding_test.cpp
	modified:   fe/fe-core/src/main/java/com/starrocks/http/rest/RestBaseAction.java
	new file:   fe/fe-core/src/test/java/com/starrocks/http/RestBaseActionTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/test/CMakeLists.txt
	both modified:   be/test/http/stream_load_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jun 11, 2025
Merged
24 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 11, 2025 16:11
@mergify mergify bot closed this Jun 11, 2025
auto-merge was automatically disabled June 11, 2025 16:12

Pull request was closed

@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 11, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@kevincai
fix conflict
c3e874f 
Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
@kevincai kevincai reopened this Jun 20, 2025
@kevincai kevincai self-assigned this Jun 20, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 20, 2025 05:42
@wanpengfei-git wanpengfei-git merged commit 2888365 into branch-3.3 Jun 20, 2025
44 of 45 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-59722 branch June 20, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincai kevincai kevincai approved these changes

Assignees

@kevincai kevincai

Labels
automerge conflicts version:3.3.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @wanpengfei-git @rohitrs1983
0