8000 [BugFix] Fix aggregate publish failed when lake table has rollup (backport #59873) by mergify[bot] · Pull Request #59940 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Fix aggregate publish failed when lake table has rollup (backport #59873) #59940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2025
Merged

[BugFix] Fix aggregate publish failed when lake table has rollup (backport #59873) #59940

merged 3 commits into from
Jun 16, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 16, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

The SharedTabletMetadata aggregates the schemas of all tablets to reduce the size of Protobuf messages, assuming that the schema IDs of all tablets are consistent. However, when a lake table has rollups, the schema IDs of tablets within the same partition may vary, leading to failures in aggregate publishing.

What I'm doing:

using a map(tablet_id to schema_id) instead of one schema_id

Fixes https://github.com/StarRocks/StarRocksTest/issues/9800, https://github.com/StarRocks/StarRocksTest/issues/9812

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull request #59873 done by [Mergify](https://mergify.com).

@sevev @mergify
[BugFix] Fix aggregate publish failed when lake table has rollup (#59873
3ab2ca4 
)

Signed-off-by: sevev <qiangzh95@gmail.com>
(cherry picked from commit ad08b12)

# Conflicts:
#	be/src/storage/lake/tablet_manager.cpp
#	be/test/storage/lake/tablet_manager_test.cpp
#	be/test/storage/lake/vacuum_test.cpp
@mergify mergify bot added the conflicts label Jun 16, 2025
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 16, 2025

Cherry-pick of ad08b12 has failed:

On branch mergify/bp/branch-3.5/pr-59873
Your branch is up to date with 'origin/branch-3.5'.

You are currently cherry-picking commit ad08b125aa.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   gensrc/proto/lake_types.proto

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/lake/tablet_manager.cpp
	both modified:   be/test/storage/lake/tablet_manager_test.cpp
	both modified:   be/test/storage/lake/vacuum_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jun 16, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 16, 2025 09:05
@mergify mergify bot closed this Jun 16, 2025
auto-merge was automatically disabled June 16, 2025 09:05

Pull request was closed

@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 16, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@sevev sevev reopened this Jun 16, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 16, 2025 09:16
sevev added 2 commits June 16, 2025 17:20
@sevev
resolve conflict
1a3cc20 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sevev
update
22612a6 
Signed-off-by: sevev <qiangzh95@gmail.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wanpengfei-git wanpengfei-git merged commit 54fd90b into branch-3.5 Jun 16, 2025
29 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.5/pr-59873 branch June 16, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevev sevev sevev approved these changes

Assignees

@sevev sevev

Labels
automerge conflicts version:3.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevev @wanpengfei-git
0