8000 [BugFix] fix modify column wrongly handled for older version table by starrocks-xupeng · Pull Request #59941 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] fix modify column wrongly handled for older version table #59941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[BugFix] fix modify column wrongly handled for older version table #59941

merged 1 commit into from
Jun 17, 2025

Conversation

starrocks-xupeng
Copy link
Contributor
@starrocks-xupeng starrocks-xupeng commented Jun 16, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

need to pass columnId to CN when doing DDL

set up 3.1.13 cluster
create table t (id int, AAA varchar(10), dt date) 
DUPLICATE KEY(`id`)
partition by range(`dt`)
(PARTITION p20250507 VALUES [("2025-05-07"), ("2025-05-08")),
PARTITION p20250508 VALUES [("2025-05-08"), ("2025-05-09")),
PARTITION p20250509 VALUES [("2025-05-09"), ("2025-05-10")))
DISTRIBUTED BY HASH(`id`) buckets 1
properties (
'replication_num'='1'
);

insert into t values ('1','abc','2025-05-09 12:00:00');

select * from t;
AAA will be abc

upgrade to 3.3.14
alter table t modify column aaa varchar(100);

select * from t;
AAA will be NULL

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@starrocks-xupeng
[BugFix] fix modify column wrongly handled for older version table
2825a6f 
Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
@starrocks-xupeng starrocks-xupeng requested a review from a team as a code owner June 16, 2025 09:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xiangguangyxg xiangguangyxg enabled auto-merge (squash) June 17, 2025 01:41
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/Column.java 2 2 100.00% []
🔵 com/starrocks/alter/SchemaChangeHandler.java 1 1 100.00% []

@xiangguangyxg xiangguangyxg merged commit 826f734 into StarRocks:main Jun 17, 2025
95 of 96 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.5 label Jun 17, 2025
@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 17, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@starrocks-xupeng @mergify
[BugFix] fix modify column wrongly handled for older version table (#…
ec4c07a 
…59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
(cherry picked from commit 826f734)
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@starrocks-xupeng @mergify
[BugFix] fix modify column wrongly handled for older version table (#…
2c1d069 
…59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
(cherry picked from commit 826f734)
mergify bot pushed a commit that referenced this pull request Jun 17, 2025
@starrocks-xupeng @mergify
[BugFix] fix modify column wrongly handled for older version table (#…
085eb47 
…59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
(cherry picked from commit 826f734)
This was referenced Jun 17, 2025
Closed
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @starrocks-xupeng
[BugFix] fix modify column wrongly handled for older version table (b…
427cfd3 
…ackport #59941) (#59960)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
Co-authored-by: starrocks-xupeng <xupeng@starrocks.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 17, 2025
@mergify @starrocks-xupeng
[BugFix] fix modify column wrongly handled for older version table (b…
d5eb953 
…ackport #59941) (#59959)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
Co-authored-by: starrocks-xupeng <xupeng@starrocks.com>
starrocks-xupeng added a commit to starrocks-xupeng/starrocks that referenced this pull request Jun 17, 2025
@starrocks-xupeng
[BugFix] fix modify column wrongly handled for older version table (b…
f66b61a 
…ackport StarRocks#59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
@starrocks-xupeng
Copy link
Contributor Author

#59977

andyziye pushed a commit that referenced this pull request Jun 17, 2025
@starrocks-xupeng
[BugFix] fix modify column wrongly handled for older version table (b…
520f1e8 
…ackport #59941) (#59977)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
AntiTopQuark pushed a commit to AntiTopQuark/starrocks that referenced this pull request Jun 19, 2025
@starrocks-xupeng @AntiTopQuark
[BugFix] fix modify column wrongly handled for older version table (S…
a281e18 
…tarRocks#59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
dengliu pushed a commit to dengliu/starrocks that referenced this pull request Jun 20, 2025 85F4
@starrocks-xupeng @dengliu
[BugFix] fix modify column wrongly handled for older version table (S…
2e48752 
…tarRocks#59941)

Signed-off-by: starrocks-xupeng <xupeng@starrocks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjun-git gengjun-git gengjun-git approved these changes

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

Assignees

@starrocks-xupeng starrocks-xupeng

Labels
3.3-merged 3.4-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@starrocks-xupeng @gengjun-git @xiangguangyxg
0