8000 [BugFix] Fix the `disk_device_id` function to aquire the device_id of an non-existent entry by its ancestor entries. (backport #59919) by mergify[bot] · Pull Request #59968 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Fix the disk_device_id function to aquire the device_id of an non-existent entry by its ancestor entries. (backport #59919) #59968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[BugFix] Fix the disk_device_id function to aquire the device_id of an non-existent entry by its ancestor entries. (backport #59919) #59968

merged 1 commit into from
Jun 17, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 17, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

We use the device_id to identify whether two disk paths locate in same disks.
The old disk_device_id function only aquires stats for the accurate path parameter, which may be not exist and cause the function failed.

What I'm doing:

Get the device_id of the given path from the current entry to its ancestor entries. If the current path does not exist, check its parent and ancestor entries.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull reque 8000 st #59919 done by [Mergify](https://mergify.com).

@GavinMar @mergify
[BugFix] Fix the disk_device_id function to aquire the device_id of…
7b63287 
… an non-existent entry by its ancestor entries. (#59919)

Signed-off-by: GavinMar <yangguansuo@starrocks.com>
(cherry picked from commit 494aca6)
@mergify mergify bot mentioned this pull request Jun 17, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2025 03:24
@wanpengfei-git wanpengfei-git merged commit e7a3f12 into branch-3.4 Jun 17, 2025
34 of 35 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-59919 branch June 17, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

Assignees

@GavinMar GavinMar

Labels
automerge version:3.4.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trueeyu @GavinMar @wanpengfei-git
0