8000 [Enhancement] Add Config param slow_lock_print_stack (backport #59967) by mergify[bot] · Pull Request #59980 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Enhancement] Add Config param slow_lock_print_stack (backport #59967) #59980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

[Enhancement] Add Config param slow_lock_print_stack (backport #59967) #59980

merged 2 commits into from
Jun 18, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 17, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

For large-scale clusters, dumpThreads can be very slow. Set slow_lock_print_stack to false if this problem occurs.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull request #59967 done by [Mergify](https://mergify.com).

@gengjun-git @mergify
[Enhancement] Add Config param slow_lock_print_stack (#59967)
ccadaed 
For large-scale clusters, dumpThreads can be very slow. Set slow_lock_print_stack to false if this problem occurs.

Signed-off-by: gengjun-git <gengjun@starrocks.com>
(cherry picked from commit 9e0faac)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/common/Config.java
@mergify mergify bot added the conflicts label Jun 17, 2025
@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 17, 2025

Cherry-pick of 9e0faac has failed:

On branch mergify/bp/branch-3.3/pr-59967
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 9e0faac862.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/common/util/concurrent/lock/LockManager.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/common/Config.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Jun 17, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2025 06:42
8000 @mergify mergify bot closed this Jun 17, 2025
auto-merge was automatically disabled June 17, 2025 06:42

Pull request was closed

@mergify Mergify
Copy link
Contributor Author
mergify bot commented Jun 17, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@gengjun-git
resolve
7a4a080 
Signed-off-by: gengjun-git <gengjun@starrocks.com>
@gengjun-git gengjun-git reopened this Jun 17, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 17, 2025 07:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wanpengfei-git wanpengfei-git merged commit 4c417d6 into branch-3.3 Jun 18, 2025
89 of 94 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-59967 branch June 18, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangsimo0 wangsimo0 wangsimo0 approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@gengjun-git gengjun-git

Labels
automerge conflicts version:3.3.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangsimo0 @gengjun-git @wanpengfei-git
0