8000 [BugFix] Filesystem cache failure in concurrent scenarios. by zhangheihei · Pull Request #60053 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Filesystem cache failure in concurrent scenarios. #60053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

[BugFix] Filesystem cache failure in concurrent scenarios. #60053

merged 1 commit into from
Jun 19, 2025

Conversation

zhangheihei
Copy link
Contributor
@zhangheihei zhangheihei commented Jun 19, 2025 •
edited
Loading

Why I'm doing:

Before shard 11724 inserts the cache, shard 10063 enters the build_filesystem_from_shard_info function, leading to a result where the same string cache_key has two std::shared_ptrstd::string objects.

I20250615 23:55:12.801891 139846642751232 staros_worker.cpp:354] StarOSWorker::insert_fs_cache: key = 4f745a4a455fa97c78a0660ba33dae18b476a308a6dc4a1d4d97ba48728644f4
I20250615 23:55:12.801900 139846642751232 staros_worker.cpp:364] StarOSWorker::insert_fs_cache: key = 4f745a4a455fa97c78a0660ba33dae18b476a308a6dc4a1d4d97ba48728644f4 , capacity = 4
I20250615 23:55:12.801905 139846642751232 staros_worker.cpp:212] StarOSWorker::get_shard_filesystem: get shard 11724 fs from cache failed.

I20250615 23:55:12.710220 139846634358528 staros_worker.cpp:193] StarOSWorker::get_shard_filesystem: build_filesystem_from_shard_info shard id = 10063.
I20250615 23:55:12.743501 139846634358528 staros_worker.cpp:354] StarOSWorker::insert_fs_cache: key = 4f745a4a455fa97c78a0660ba33dae18b476a308a6dc4a1d4d97ba48728644f4
I20250615 23:55:12.743510 139846634358528 staros_worker.cpp:364] StarOSWorker::insert_fs_cache: key = 4f745a4a455fa97c78a0660ba33dae18b476a308a6dc4a1d4d97ba48728644f4 , capacity = 4
I20250615 23:55:12.743515 139846634358528 staros_worker.cpp:208] StarOSWorker::get_shard_filesystem: get shard 10063 fs from cache after create.
I20250615 23:55:12.743518 139846634358528 staros_worker.cpp:371] StarOSWorker::erase_fs_cache: key = 4f745a4a455fa97c78a0660ba33dae18b476a308a6dc4a1d4d97ba48728644f4 , capacity = 4

What I'm doing:

Fixes #58539

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

starrocks-cr[bot]
starrocks-cr bot reviewed Jun 19, 2025
View reviewed changes
@zhangheihei
fix filesystem cache invalid
2f2a1b1 
Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
@zhangheihei zhangheihei force-pushed the bugfix-filesystem-cache-invalid branch from b5d9fa9 to 2f2a1b1 Compare June 19, 2025 04:19
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@xiangguangyxg xiangguangyxg enabled auto-merge (squash) June 19, 2025 06:00
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 9 / 9 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/staros_worker.cpp 9 9 100.00% []

@xiangguangyxg xiangguangyxg merged commit e51bda8 into StarRocks:main Jun 19, 2025
66 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.5

@github-actions github-actions bot removed the 3.4 label Jun 19, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 19, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 19, 2025 •
edited
Loading

backport branch-3.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor
mergify bot commented Jun 19, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@zhangheihei @mergify
[BugFix] Filesystem cache failure in concurrent scenarios. (#60053)
e4b8fa9 
Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
(cherry picked from commit e51bda8)

# Conflicts:
#	be/test/service/staros_worker_test.cpp
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@zhangheihei @mergify
[BugFix] Filesystem cache failure in concurrent scenarios. (#60053)
f6063ca 
Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
(cherry picked from commit e51bda8)
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
22 tasks
mergify bot pushed a commit that referenced this pull request Jun 19, 2025
@zhangheihei @mergify
[BugFix] Filesystem cache failure in concurrent scenarios. (#60053)
db0415b 
Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
(cherry picked from commit e51bda8)

# Conflicts:
#	be/test/service/staros_worker_test.cpp
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
22 tasks
wanpengfei-git pushed a commit that referenced this pull request Jun 19, 2025
@mergify @zhangheihei
[BugFix] Filesystem cache failure in concurrent scenarios. (backport #…
eae8225 
…60053) (#60063)

Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
Co-authored-by: zhanghe <edwinhzhang@tencent.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 19, 2025
@mergify @zhangheihei @kevincai
[BugFix] Filesystem cache failure in concurrent scenarios. (backport #…
486fc46 
…60053) (#60064)

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Co-authored-by: zhanghe <edwinhzhang@tencent.com>
Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>
AntiTopQuark pushed a commit to AntiTopQuark/starrocks that referenced this pull request Jun 19, 2025
@zhangheihei @AntiTopQuark
[BugFix] Filesystem cache failure in concurrent scenarios. (StarRocks…
04e67e8 
…#60053)

Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
Signed-off-by: AntiTopQuark <AntiTopQuark1350@outlook.com>
dengliu pushed a commit to dengliu/starrocks that referenced this pull request Jun 20, 2025
@zhangheihei @dengliu
[BugFix] Filesystem cache failure in concurrent scenarios. (StarRocks…
244014d 
…#60053)

Signed-off-by: edwinhzhang <edwinhzhang@tencent.com>
wanpengfei-git pushed a commit that referenced this pull request Jun 20, 2025
@mergify @zhangheihei @kevincai
[BugFix] Filesystem cache failure in concurrent scenarios. (backport #…
79b37d1 
…60053) (#60062)

Signed-off-by: Kevin Cai <kevin.cai@celerdata.com>
Co-authored-by: zhanghe <edwinhzhang@tencent.com>
Co-authored-by: Kevin Cai <kevin.cai@celerdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@kevincai kevincai kevincai approved these changes

@starrocks-xupeng starrocks-xupeng starrocks-xupeng approved these changes

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

Assignees

@zhangheihei zhangheihei

Labels
3.3-merged 3.4-merged 3.5-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The compaction task is occasionally extremely slow, blocking at column_iterator_init.
4 participants
@zhangheihei @kevincai @starrocks-xupeng @xiangguangyxg
0