8000 [BugFix] Fix assertion failure for insert stmt planning of shuffle for primary key table (backport #60052) by mergify[bot] · Pull Request #60082 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[BugFix] Fix assertion failure for insert stmt planning of shuffle for primary key table (backport #60052) #60082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[BugFix] Fix assertion failure for insert stmt planning of shuffle for primary key table (backport #60052) #60082

merged 1 commit into from
Jun 20, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 19, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

If we create a table satisify the following condition: 1. primary key table, 2. replication_num > 1
3. without replicate storage. In this case, if we execute a partial update insert stmt, we will get
assertion failure because we need to build the shuffle property in this case but if insert stmt is
in partial update mode, the list of ColumnRefOperator has not the same size of full schema.

What I'm doing:

We just use outputFullSchema which generated by partial update checking instead of Table::getFullSchema()

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull request #60052 done by [Mergify](https://mergify.com).

@srlch @mergify
[BugFix] Fix assertion failure for insert stmt planning of shuffle fo…
f38be6b 
…r primary key table (#60052)

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit 6c6ed0d)
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 19, 2025 10:15
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@wanpengfei-git wanpengfei-git merged commit c0902c3 into branch-3.5 Jun 20, 2025
37 of 38 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.5/pr-60052 branch June 20, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvin-celerdata alvin-celerdata alvin-celerdata approved these changes

Assignees

@srlch srlch

Labels
automerge version:3.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alvin-celerdata @wanpengfei-git @srlch
0