8000 [UT] Fix unstable ut for Restore cause by @Mocked annotation for SystemInfoService (backport #60078) by mergify[bot] · Pull Request #60083 · StarRocks/starrocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[UT] Fix unstable ut for Restore cause by @Mocked annotation for SystemInfoService (backport #60078) #60083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[UT] Fix unstable ut for Restore cause by @Mocked annotation for SystemInfoService (backport #60078) #60083

merged 1 commit into from
Jun 20, 2025

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Jun 19, 2025 •
edited by wanpengfei-git
Loading

Why I'm doing:

Missing 1 invocation to: will be throw when running the RestoreJobTest for some SystemInfoService stack
The reason is the SystemInfoService object has the @Mocked annotation which means all member functions are not mentioned in Expectations{} should not be called in the UT. But some background thread will call such functions and get unexpected exception. @Mocked annotation will affect the Class itself, so even a new object is new in another thread, it still be affected by the rule.

What I'm doing:

New a object for SystemInfoService and use partial mocking for jmockit.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3
This is an automatic backport of pull request #60078 done by [Mergify](https://mergify.com).

@srlch @mergify
[UT] Fix unstable ut for Restore cause by @mocked annotation for Syst…
36b564c 
…emInfoService (#60078)

Signed-off-by: srlch <linzichao@starrocks.com>
(cherry picked from commit c7aade8)
@mergify mergify bot mentioned this pull request Jun 19, 2025
Merged
22 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) June 19, 2025 10:50
@wanpengfei-git wanpengfei-git merged commit 9a40c51 into branch-3.4 Jun 20, 2025
43 of 47 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-60078 branch June 20, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? 6537 Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

Assignees

@srlch srlch

Labels
automerge version:3.4.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyb @wanpengfei-git @srlch
0