[Enhancement] bump up breakpad to 2024.02.16 to fix crash in dump_syms #60005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincai
reviewed
Jun 18, 2025
There was a problem hiding this comment.
breakpad build failed on centos7 environment.
2025-06-17T17:50:39.4705575Z #9 2755.4 src/common/linux/dump_symbols.cc: In function ‘bool {anonymous}::IsCompressedHeader(const typename ElfClass::Shdr*)’:
2025-06-17T17:50:39.4706359Z #9 2755.4 src/common/linux/dump_symbols.cc:298:31: error: ‘SHF_COMPRESSED’ was not declared in this scope
2025-06-17T17:50:39.4706818Z #9 2755.4 298 | return (section->sh_flags & SHF_COMPRESSED) != 0;
2025-06-17T17:50:39.4707140Z #9 2755.4 | ^~~~~~~~~~~~~~
2025-06-17T17:50:39.4707942Z #9 2755.4 src/common/linux/dump_symbols.cc: In function ‘std::pair<unsigned char*, long unsigned int> {anonymous}::UncompressSectionContents(uint64_t, const uint8_t*, uint64_t, uint64_t)’:
2025-06-17T17:50:39.4708913Z #9 2755.4 src/common/linux/dump_symbols.cc:363:27: error: ‘ELFCOMPRESS_ZLIB’ was not declared in this scope; did you mean ‘ELFCOMPRESS_ZSTD’?
2025-06-17T17:50:39.4709569Z #9 2755.4 363 | if (compression_type == ELFCOMPRESS_ZLIB) {
2025-06-17T17:50:39.4709871Z #9 2755.4 | ^~~~~~~~~~~~~~~~
2025-06-17T17:50:39.4710155Z #9 2755.4 | ELFCOMPRESS_ZSTD
2025-06-17T17:50:39.4710936Z #9 2755.4 src/common/linux/dump_symbols.cc: In function ‘bool {anonymous}::DwarfCFIRegisterNames(const typename ElfClass::Ehdr*, std::vector<std::__cxx11::basic_string<char> >*)’:
2025-06-17T17:50:39.4711909Z #9 2755.4 src/common/linux/dump_symbols.cc:549:10: error: ‘EM_RISCV’ was not declared in this scope
2025-06-17T17:50:39.4712295Z #9 2755.4 549 | case EM_RISCV:
2025-06-17T17:50:39.4712516Z #9 2755.4 | ^~~~~~~~
2025-06-17T17:50:39.4713097Z #9 2755.4 src/common/linux/dump_symbols.cc: In function ‘const char* {anonymous}::ElfArchitecture(const typename ElfClass::Ehdr*)’:
2025-06-17T17:50:39.4713787Z #9 2755.4 src/common/linux/dump_symbols.cc:1125:10: error: ‘EM_RISCV’ was not declared in this scope
2025-06-17T17:50:39.4714215Z #9 2755.4 1125 | case EM_RISCV: return "riscv";
2025-06-17T17:50:39.4714473Z #9 2755.4 | ^~~~~~~~
@kevincai these macros are present in /usr/include/elf.h. unavailable on centos7 since its pretty old. dont observe the same failure on ubuntu. how about a patch file to add these macros to dump_symbols.cc? |
Yes, it's acceptable. |
|
@Mergifyio rebase |
Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
✅ Branch has been successfully rebased |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
kevincai
approved these changes
Jun 21, 2025
alvin-celerdata
approved these changes
Jun 21, 2025
|
@Mergifyio backport branch-3.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 21, 2025
#60005) we are using and older version of dump_syms that doesn’t understand the .relr.dyn section Fixes #60004 update breakpad to version breakpad-2024.02.16 $ bash thirdparty/minidump/gen_minidump_symbols.sh starrocks_be'size (2153mb) reduced to (556mb) symbol file is at /home/ubuntu/starrocks/output/be/symbols/starrocks_be/AC7FAB7F8B5BF82100000000000000000 Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com> (cherry picked from commit d96b521)
Merged
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are using and older version of dump_syms that doesn’t understand the .relr.dyn section
Fixes #60004
update breakpad to version breakpad-2024.02.16
$ bash thirdparty/minidump/gen_minidump_symbols.sh
starrocks_be'size (2153mb) reduced to (556mb)
symbol file is at /home/ubuntu/starrocks/output/be/symbols/starrocks_be/AC7FAB7F8B5BF82100000000000000000
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: