8000 AsyncJob fail when client disconnected by kuznetsov-kd · Pull Request #1532 · SteamRE/SteamKit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

AsyncJob fail when client disconnected #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2025
Merged

AsyncJob fail when client disconnected #1532

merged 4 commits into from
May 2, 2025

Conversation

kuznetsov-kd
Copy link
Contributor

@xPaw
Copy link
Member
xPaw commented May 2, 2025 •
edited
Loading

I just realized this is kind of a breaking change. If consumer code waited for the await to throw and then retried the request, previously they would be retrying against a connected client.

Which is a dumb assumption to make, but should at least be noted in the release notes.

Can you fix the build please?

75E4 xPaw merged commit 446bbe9 into SteamRE:master May 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xPaw xPaw xPaw approved these changes

@JustArchi JustArchi JustArchi approved these changes

Assignees
No one assigned
Labels
breaking change bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuznetsov-kd @xPaw @JustArchi
0