Better calc individual juice fix (Issue #711) #737
Conversation
|
hey! thank you for making a PR! in short: fixing just Wee might be missing the root cause. I really appreciate the work though, finding what made wee wrong in the first place is really good. |
|
(just noticed your PR got closed. Github PRs require you to keep the branch not deleted, sorry) |
|
Yeah, I realized that almost all the cards that upgrade after a card is scored have this same issue, pretty sure it's because better calc always juices the card in play if a scored_card value isn't in the return table. I'll probably reopen with an fix for all of them |
|
Reopened with fixes for Lucky Cat and 8-Ball as well |
|
Temp fix for now, looking into a fix for the deeper issue |
|
I'm not able to test right now, but I'm pretty sure that moving |
|
That does fix this issue, but it also causes jokers like hiker to have scoring animations on the joker rather than the card |
|
May have found a working solution, testing now |
|
Seems to be working, but it is possible that an anim could break if it relies on two different cards juicing from effect and extra |
|
Yeah looks like this would definitely break any jokers that are using the extra table to add messages to different things. I'll have a proper look after work later on and see what we can figure out. |
|
This is probably the most reasonable solution I've found currently. Since card_eval_status_text will juice the card, I've changed the scored_card:juice_up in SMODS.calculate_effect so that it only happens when the message card is not the same as scored_card |
|
This fixes the problem with wee, lucky cat and 8 ball, and hopefully shouldn't have an impact on uses of the extra table |
d8ce273 to
f1c8c26
Compare
Slight change to the SMODS.calculate_effect function to make some cards stop juicing wrong
Additional Info: