8000 Added SMODS.JimboQuip by Kekulism · Pull Request #745 · Steamodded/smods · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added SMODS.JimboQuip #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added SMODS.JimboQuip #745

wants to merge 4 commits into from

Conversation

Kekulism
Copy link
Contributor
@Kekulism Kekulism commented Jun 4, 2025 •
edited
Loading

Added a new GameObject, SMODS.JimboQuip which serves to allow mods to easily add new quips for Jimbo to say on run wins/losses. All you need is a key and a type set to 'win' or 'loss', as well as a loc_txt table or matching entry in a localization file.

Quips can be filtered out or increase their chance of appearing with the filter function. Additionally, you can set an extra table (or function that returns a table) to specify extra details like changing the center of the card character or the colors of its materialization or particles.

Decks can also filter out quips with an added quip_filter function to SMODS.Back. This allows certain decks to only show certain quips. quip_filter is called at the same time as filter is for every quip that can be added to the pool, and functions partially the same. returning false will prevent it from being shown.

Required parameters: key, type
Basic Example:

SMODS.JimboQuip{
    key = 'custom_wq_1,
    type = 'loss',
    loc_txt = {
        ['en-us'] = {
            "get gud",
        }
    }
}

Advanced example:
This quip only appears if you win the run with Hanging Chad, and sets it rarity higher so you are almost guaranteed to see it. It also sets the center for the card character to appear as hanging chad instead of the basic joker, and changes its particle colors.

SMODS.JimboQuip{
    key = 'custom_wq_1',
    type = 'win',
    extra = { center = G.P_CENTERS.j_hanging_chad, particle_colours = { G.C.RED, G.C.WHITE, G.C.BLACK } }
    filter = function()
        if next(SMODS.find_card('j_hanging_chad')) then
            return true, { rarity = 100 }
        end
        return false
    end,
    loc_txt = {
        ['en-us'] = {
            "Hanging Chad is for Chads!",
        }
    }
}

Additional Info:

  • I didn't modify api's or I've made a PR to the wiki repo.
  • I didn't modify api's or I've updated lsp definitions.
  • [X ] I didn't make new lovely files or all new lovely files have appropriate priority.

Kekulism added 4 commits June 3, 2025 22:06
@Kekulism
SMODS.JimboQuip
2da4913
@Kekulism
Merge branch 'main' of https://github.com/Kekulism/Steamodded
976a3f7
@Kekulism
weighted rarity
12d3908 
- Renamed in_pool to filter for JimboQuips
- Added weighted rarity to filtering, allowing quips to increase in chance of showing under certain circumstances
@Kekulism
color customization
1207952
@Kekulism Kekulism requested a review from Aurelius7309 as a code owner June 4, 2025 03:09
@Catzzadilla
Copy link

man I sure do hope this gets in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius7309 Aurelius7309 Awaiting requested review from Aurelius7309 Aurelius7309 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kekulism @Catzzadilla
0