8000 jszip 3.6.0 breaks browserify with tinyify · Issue #746 · Stuk/jszip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

jszip 3.6.0 breaks browserify with tinyify #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
feross opened this issue Feb 11, 2021 · 1 comment
Open

jszip 3.6.0 breaks browserify with tinyify #746

feross opened this issue Feb 11, 2021 · 1 comment
Labels
bug

Comments

@feross
Copy link
feross commented Feb 11, 2021

Since upgrading jszip from 3.5.0 to 3.6.0, my browserify build has stopped working. We use one browserify plugin, the popular tinyify package to do minification and other optimizations to the build.

Here's the exact command:

browserify --plugin tinyify .

It produces a bundle successfully, but when run in the browser it produces the following error:

Uncaught ReferenceError: require is not defined

It's likely the fix to #724 has caused this. Any ideas what the issue might be?
feross added a commit to webtorrent/instant.io that referenced this issue Feb 11, 2021
@feross
lock jszip
600959c 
Stuk/jszip#746
@christianhaller
Copy link

My workaround is:

import JSZip from "jszip/lib/index.js";

@jonkoops jonkoops added the bug label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? 45D2 Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@feross @christianhaller @jonkoops
0