feat(syslogexporter): add option to skip certificate verfication #983
Conversation
f692e2c to
c876ed8
Compare
c87deec to
ce5bebb
Compare
|
Isn't there any helpers for http client in Otel? |
| - `ca_certificate` [tcp only] - A publicly verifiable server certificate | ||
| - `certificate` [tcp only] - certificate for mTLS communication (client certificate) | ||
| - `key` [tcp only] - Key for mTLS communication (client key) | ||
| - `skip_certificate_verification` - [tcp only] If set to `true` then any certificate presented by the server is accepted and any host name in that certificate |
There was a problem hiding this comment.
Can we group configuration under common key?
There was a problem hiding this comment.
I will try to use https://github.com/open-telemetry/opentelemetry-collector/blob/7cf999e4526c9e65f5dbedb67c90cbe2c79e4f54/config/configtls/configtls.go#L66 and make settings similar to configuration described here: https://github.com/open-telemetry/opentelemetry-collector/blob/exporter/otlphttpexporter/v0.71.0/config/configtls/README.md
c876ed8 to
1a0d502
Compare
We don't use http in syslogexporter, we use only TCP/UDP. |
Otel core does have a helper for TLS though: https://github.com/open-telemetry/opentelemetry-collector/tree/main/config/configtls, which we should use, though not necessarily in this PR. |
@swiatekm-sumo I mentioned it in this comment: #983 (comment) |
4ef423d to
6d01599
Compare
|
Configuration for TLS is changed in this PR and uses https://github.com/open-telemetry/opentelemetry-collector/tree/main/config/configtls, I assume that this kind of changes are not treated as breaking changes because syslog exporter has alpha stability https://github.com/open-telemetry/opentelemetry-collector#alpha |
6d01599 to
4d376c0
Compare
…ry configtls This make that setting are the same as described in https://github.com/open-telemetry/opentelemetry-collector/tree/main/config/configtls
4d376c0 to
03cc8d0
Compare
This allows using self-signed certificates