8000 fix(scripts/install.ps1): treat app as not installed if otelcol-sumo.exe is missing by amdprophet · Pull Request #1061 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(scripts/install.ps1): treat app as not installed if otelcol-sumo.exe is missing #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

amdprophet
Copy link
Contributor
@amdprophet amdprophet commented Mar 10, 2023

If the Sumo Logic OpenTelemtry Collector is installed and the otelcol-sumo.exe binary does not exist then the install.ps1 script will currently throw an error and not execute. This change will show a warning and continue as if no installation was detected.

Screenshot 2023-03-10 at 14 55 07

Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
@amdprophet amdprophet requested a review from a team as a code owner March 10, 2023 22:54
Signed-off-by: Justin Kolberg <amd.prophet@gmail.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 10, 2023
@amdprophet amdprophet merged commit 3b7ea82 into main Mar 13, 2023
@amdprophet amdprophet deleted the fix/install-ps1-missing-exe branch March 13, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0