8000 fix: do not send html special characters as unicode by sumo-drosiek · Pull Request #1145 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not send html special characters as unicode #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2023
Merged

fix: do not send html special characters as unicode #1145

merged 2 commits into from
May 31, 2023

Conversation

sumo-drosiek
Copy link
Contributor
@sumo-drosiek sumo-drosiek commented May 31, 2023 •
edited
Loading

By default we are encoding htlm characters like <, >, &. It is unexpected for our customers

log:

{"log": "<<<<>>>>>"}

output to Sumo Logic

2023-05-31T06:01:09.357Z DEBUG [receiver_mock::router] log => {"log":"{\"log\": \"\u003c\u003c\u003c\u003c\u003e\u003e\u003e\u003e\u003e\"}","log.file.path_resolved":"/home/drosiek/projects/sumologic-otel-collector/tmp/logs/unicode.json","timestamp":1685512869155}

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner May 31, 2023 06:34
@github-actions github-actions bot added go documentation Improvements or additions to documentation labels May 31, 2023
Dominik Rosiek added 2 commits May 31, 2023 08:59
fix: do not send htlm special characters as unicode
e2d311d 
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
chore: changelog
e020a82
@sumo-drosiek
Copy link
Contributor Author

The log in SumoLogic UI looks the same (<), but it doesn't work with search as expected (require using \u003c)

@andrzej-stencel
Copy link
Contributor

This issue only affected the json log formatting, is this correct?

@sumo-drosiek
Copy link
Contributor Author

This issue only affected the json log formatting, is this correct?

yes

@sumo-drosiek sumo-drosiek merged commit 882354b into main May 31, 2023
@sumo-drosiek sumo-drosiek deleted the fix-html-export branch May 31, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@aboguszewski-sumo aboguszewski-sumo aboguszewski-sumo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sumo-drosiek @andrzej-stencel @swiatekm @aboguszewski-sumo
0