feat: update list of components #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28eec4d to
4738fbb
Compare
swiatekm
suggested changes
Jul 6, 2023
4738fbb to
42a0a5b
Compare
42a0a5b to
8b7e471
Compare
swiatekm
approved these changes
Jul 6, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
8b7e471 to
5613a39
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
5613a39 to
f3d81e5
Compare
sumo-drosiek
commented
Jul 6, 2023
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
ada2cfb to
dc79212
Compare
sumo-drosiek
commented
Jul 7, 2023
Comment on lines
88
to
93
| working-directory: ./otelcolbuilder/cmd | ||
| run: | | ||
| go version -m ${{ steps.set_filename.outputs.filename }} | \ | ||
| grep -E "/(receiver|exporter|processor|extension)/" | \ | ||
| { grep -E "/(receiver|exporter|processor|extension)/" || true; } | \ | ||
| tee otelcol-sumo-${{matrix.arch_os}}_modules.txt | ||
|
|
There was a problem hiding this comment.
@swiatekm-sumo not sure, why do we have Show included modules in CI?
There was a problem hiding this comment.
I think this was a way to verify we actually built with the modules we intended. But this can be done by building the binary and running otelcol-sumo components now as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new components: