feat(sumologicexporter): add option to decompose OTLP Histograms #1197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7488c4e to
dcf5d1a
Compare
dcf5d1a to
451ac22
Compare
sumo-drosiek
approved these changes
Jul 19, 2023
451ac22 to
263e2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumo doesn't currently support OTLP Histograms. In the interim, we can at least make sure sending a histogram via OTLP and Prometheus gives the same result. We already have the logic for the Prometheus format, and this PR also implements it for OTLP. This comes down to decomposing the Histogram into individual sum, count and bucket metrics.
The behaviour is configurable and disabled by default.