8000 chore: update otelcol core to v0.84.0 by andrzej-stencel · Pull Request #1235 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update otelcol core to v0.84.0 #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

andrzej-stencel
Copy link
Contributor

No description provided.

@andrzej-stencel andrzej-stencel requested a review from a team as a code owner September 5, 2023 07:58
@github-actions github-actions bot added documentation Improvements or additions to documentation go labels Sep 5, 2023
Copy link
Contributor
@aboguszewski-sumo aboguszewski-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a changelog entry and fix failing CI please (rerunning should be enough, but who knows)

This is needed to get rid of the error message when building collector:

```console
Error: failed to update go.mod: exit status 1. Output:
go: found github.com/SumoLogic/sumologic-otel-collector/pkg/configprovider/globprovider in github.com/SumoLogic/sumologic-otel-collector/pkg/configprovider/globprovider v0.0.0-00010101000000-000000000000
github.com/SumoLogic/sumologic-otel-collector imports
        go.opentelemetry.io/collector/confmap imports
        github.com/knadh/koanf/maps: ambiguous import: found package github.com/knadh/koanf/maps in multiple modules:
        github.com/knadh/koanf v1.5.0 (/home/andrzej/go/pkg/mod/github.com/knadh/koanf@v1.5.0/maps)
        github.com/knadh/koanf/maps v0.1.1 (/home/andrzej/go/pkg/mod/github.com/knadh/koanf/maps@v0.1.1)
github.com/SumoLogic/sumologic-otel-collector imports
        go.opentelemetry.io/collector/confmap imports
        github.com/knadh/koanf/providers/confmap: ambiguous import: found package github.com/knadh/koanf/providers/confmap in multiple modules:
        github.com/knadh/koanf v1.5.0 (/home/andrzej/go/pkg/mod/github.com/knadh/koanf@v1.5.0/providers/confmap)
        github.com/knadh/koanf/providers/confmap v0.1.0 (/home/andrzej/go/pkg/mod/github.com/knadh/koanf/providers/confmap@v0.1.0)
```
Without it, the ambiguous dependency error still persists. 🤷
@andrzej-stencel andrzej-stencel enabled auto-merge (rebase) September 5, 2023 09:15
@andrzej-stencel andrzej-stencel merged commit efc96ca into main Sep 5, 2023
@andrzej-stencel andrzej-stencel deleted the update-ot-v0.84.0 branch September 5, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0