OpAMP agent type, version, and UID from collector resource and buildinfo #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <portertech@gmail.com>
ccressent
approved these changes
Sep 29, 2023
Signed-off-by: Sean Porter <portertech@gmail.com>
swiatekm
approved these changes
Oct 3, 2023
Signed-off-by: Sean Porter <portertech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request addresses a TODO, producing a meaningful reported OpAMP agent type, version, and UID (which is also inline with upstream). Collector
semconvis used to ensure the correct collector resource attributes are used. If the resource attributes are not set, the collector build info is used.