8000 chore: Upgraded otel core to 0.108.0 by chan-tim-sumo · Pull Request #1678 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: Upgraded otel core to 0.108.0 #1678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

chore: Upgraded otel core to 0.108.0 #1678

merged 1 commit into from
Oct 3, 2024

Conversation

chan-tim-sumo
Copy link
Contributor
@chan-tim-sumo chan-tim-sumo commented Sep 30, 2024 •
edited
Loading

Summary

  • Upgraded to v108
  • 4 points I want to highlight:

    • repo was changed from github.com/open-telemetry/opentelemetry-collector to github.com/open-telemetry/opentelemetry-collector-releases for curling the binary

    • remove @$(MAKE) ensure-correct-builder-version in Makefile because the check will show (devel) isn't the same as 0.108.0 to unblock failed build

      • Was debugging an version: (devel) output showing up from upstream v107+
      • 2024-09-30T12:15:44.182-0700 INFO internal/command.go:127 OpenTelemetry Collector Builder {"version": "(devel)"}
      • the change will be released in 0.111.0, so during in v111/v112 release, the lines can be added back in Makefile

    • Deprecated functions:

      • NewCommandMustSetProvider was deprecated in v107 -> use NewCommand
      • expandconverter was deprecated in v107: https://github.com/open-telemetry/opentelemetry-collector/releases/tag/v0.107.0 -> use envprovider 
        •  opamp_agent.go:458:52: SA1019: expandconverter.NewFactory is deprecated: [v0.107.0] 
 BASH-style env var expansion is deprecated. 
 Use the envprovider instead to expand ${FOO} and ${env:FOO}. 
 Using the expandconverter with confmap.Resolver will cause double escaping, 
 so $$$$ -> $ instead of $$. (staticcheck)
 ConverterFactories: []confmap.ConverterFactory{expandconverter.NewFactory()},
      • NewInformer in client-go v0.31.1 deprecated in rawk8seventreceiver: https://pkg.go.dev/k8s.io/client-go/tools/cache#NewInformer -> use InformerOptions

    • just a heads up for the future, in upstream components

      • googlecloudmonitoringreceiver was added upstream BUT its in development state, we start adding to .otelcolbuilder and README once in alpha+

Testing

go test -skip '^TestValidateConfigs$' -trimpath -parallel 1 ./...
ok      github.com/SumoLogic/sumologic-otel-collector   29.893s

@chan-tim-sumo chan-tim-sumo requested a review from a team as a code owner September 30, 2024 19:27
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_v108upgrade branch 4 times, most recently from 93fecff to aa3803f Compare September 30, 2024 23:16
rnishtala-sumo
rnishtala-sumo reviewed Oct 1, 2024
View reviewed changes
@chan-tim-sumo chan-tim-sumo force-pushed the chan-tim_v108upgrade branch 9 times, most recently from b11efa1 to 389abdd Compare October 2, 2024 17:32
chan-tim-sumo
chan-tim-sumo commented Oct 2, 2024
View reviewed changes
@rnishtala-sumo
Copy link
Contributor

@chan-tim-sumo I think we're good to release an RC, thanks for all the effort you put into this!

@chan-tim-sumo chan-tim-sumo merged commit ef1d4d4 into main Oct 3, 2024
43 checks passed
@chan-tim-sumo chan-tim-sumo deleted the chan-tim_v108upgrade branch October 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnishtala-sumo rnishtala-sumo rnishtala-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chan-tim-sumo @rnishtala-sumo
0