8000 feat(k8s_tagger): Added pagination when fetching pods from the k8s List API by rnishtala-sumo · Pull Request #1689 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(k8s_tagger): Added pagination when fetching pods from the k8s List API #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 22, 2024
Merged

feat(k8s_tagger): Added pagination when fetching pods from the k8s List API #1689

merged 3 commits into from
Oct 22, 2024

Conversation

rnishtala-sumo
Copy link
Contributor

Added pagination when fetching pods from the k8s List API.

Unset the ResourceVersion to get the MostRecent change for an object
https://kubernetes.io/docs/reference/using-api/api-concepts/#resource-versions

@rnishtala-sumo rnishtala-sumo requested a review from a team as a code owner October 21, 2024 22:04
amdprophet
amdprophet reviewed Oct 21, 2024
View reviewed changes
@rnishtala-sumo rnishtala-sumo force-pushed the dev-build/fetch-pods branch 3 times, most recently from 7db2a4a to f9a6ae6 Compare October 22, 2024 16:23
amdprophet
amdprophet approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor
@amdprophet amdprophet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rnishtala-sumo rnishtala-sumo merged commit f05c06a into main Oct 22, 2024
75 checks passed
@rnishtala-sumo rnishtala-sumo deleted the dev-build/fetch-pods branch October 22, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echlebek echlebek echlebek left review comments

@amdprophet amdprophet amdprophet approved these changes

@chan-tim-sumo chan-tim-sumo chan-tim-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnishtala-sumo @amdprophet @echlebek @chan-tim-sumo
0