8000 otelcol-config: add timezone support by Gourav2906 · Pull Request #1770 · SumoLogic/sumologic-otel-collector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

otelcol-config: add timezone support #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 9, 2025
Merged

otelcol-config: add timezone support #1770

merged 7 commits into from
Jun 9, 2025

Conversation

Gourav2906
Copy link
Contributor

Add support to timezone so that we can use it in add collector workflow

@Gourav2906 Gourav2906 requested a review from a team as a code owner June 4, 2025 08:23
@Gourav2906 Gourav2906 mentioned this pull request Jun 4, 2025
Merged
@Gourav2906 Gourav2906 requested a review from echlebek June 4, 2025 08:50
rnishtala-sumo
rnishtala-sumo reviewed Jun 4, 2025
View reviewed changes
@Gourav2906 Gourav2906 mentioned this pull request Jun 5, 2025
Merged
@Gourav2906 Gourav2906 requested a review from rnishtala-sumo June 5, 2025 15:13
rnishtala-sumo
rnishtala-sumo reviewed Jun 5, 2025
View reviewed changes
@jagan2221
Copy link
Contributor

LGTM, please check the failing tests. Hope we tested the flag with both remote and locally managed collectors.

echlebek
echlebek requested changes Jun 8, 2025
View reviewed changes
Copy link
Collaborator
@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m concerned that this will conflict with Go stdlib’s usual handling of timezones. I would like the team to assess if there are any issues or edge cases with doing this before proceeding with merge.

echlebek
echlebek approved these changes Jun 9, 2025
View reviewed changes
Copy link
Collaborator
@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once tests pass

@Gourav2906
Copy link
Contributor Author

All tests are passing , so merging this

@Gourav2906 Gourav2906 merged commit 091050a into main Jun 9, 2025
43 checks passed
@Gourav2906 Gourav2906 deleted the timezone branch June 9, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnishtala-sumo rnishtala-sumo rnishtala-sumo left review comments

@echlebek echlebek echlebek approved these changes

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gourav2906 @jagan2221 @echlebek @rnishtala-sumo @ggarg2906sumo
0