8000 Carthage migrating a project from framework bundles to XCFrameworks by nickaroot · Pull Request #497 · Swinject/Swinject · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Carthage migrating a project from framework bundles to XCFrameworks #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Carthage migrating a project from framework bundles to XCFrameworks #497

wants to merge 2 commits into from

Conversation

nickaroot
Copy link
@nickaroot nickaroot commented Aug 23, 2021 •
edited
Loading

Hey, there is awesome Carthage feature for Xcode 12+ (https://github.com/Carthage/Carthage#migrating-a-project-from-framework-bundles-to-xcframeworks) with no need to apply a workaround

It's could be cool to merge it into a new 'xcframework' branch like an optional feature

Anyone can use it with carthage update --use-xcframeworks

@yoichitgy yoichitgy requested review from 1ucas and mpdifran August 23, 2021 08:46
@yoichitgy
Copy link
Member

Thanks, @nickaroot for making the PR! Supporting XCFrameworks is nice😃

@mpdifran Would you review the PR? I think you have some idea about XCFrameworks.

@1ucas Would you check whether we should update project.yml to configure the project?

@1ucas
Copy link
Member
1ucas commented Aug 23, 2021

Sure! I'll be on it today.

@mpdifran
Copy link
Member

Yeah I can take a look to make sure it still works for xcframeworks and old fat frameworks!

@nickaroot
Copy link
Author

Not sure it still works with usual frameworks (arm64 not excluded)

Makes sense to merge it into 'xcframework' branch, not master

@mpdifran
Copy link
Member

Ah gotcha, I thought we'd be able to avoid making a breaking change on Swinject for this, but looks like that's unavoidable.

1ucas
1ucas requested changes Aug 28, 2021
View reviewed changes
Copy link
Member
@1ucas 1ucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @nickaroot !
As you can see at the travis.yml file, we now enforce the project generation at our CI server.

So, to unsure everything will work as expected and we'll keep consistent project configurations across builds, all changes at the Swinject.xcodeproj must also be made at the project.yml template.

@nickaroot
Copy link
Author

Changes added, successfully tested with xcodegen generate and carthage build --use-xcframeworks --no-skip-current

@willemfrishert willemfrishert mentioned this pull request Sep 9, 2021
Closed
@tkohout tkohout mentioned this pull request Sep 19, 2021
Closed
@yoichitgy
Copy link
Member

Sorry, I merged PR #502 that might solve the same issue before reminding myself of this PR 🙇‍♂️

@nickaroot Did PR #502 solve the same issue? or do we have some differences in this PR to merge?

@mpdifran mpdifran removed their request for review June 23, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ucas 1ucas 1ucas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickaroot @yoichitgy @1ucas @mpdifran @nickaroot42
0