8000 Insert duplicate Customer on checkout for repeating guest customers. · Issue #13201 · Sylius/Sylius · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

Insert duplicate Customer on checkout for repeating guest customers. #13201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
acornforth opened this issue Oct 13, 2021 · 3 comments
Closed

Insert duplicate Customer on checkout for repeating guest customers. #13201

acornforth opened this issue Oct 13, 2021 · 3 comments
Labels
Bug Confirmed bugs or bugfixes.

Comments

@acornforth
Copy link
Contributor

Sylius version affected: 1.7 | 1.8 | 1.9 | 1.10

Description
At checkout, repeat guest customers who enter their email address with a different spelling results in a 500 error due to attempting to insert duplicate record (email)

Steps to reproduce

  • Checkout as guest entering the email address with a single capital letter.
  • Checkout as guest again with the same email, this time all lowercase.

Possible Solution
Modify the Form Event Listeners on CustomerCheckoutGuestType and CustomerGuestType to look up customer by emailCanonical instead of email
acornforth added a commit to acornforth/Sylius that referenced this issue Oct 13, 2021
@acornforth
[Core][Checkout] fixed Sylius#13201
08fced6 
use canonicalized email for customer lookup on CustomerGuestFormTypes

Caused insert duplicate errors on customer table for repeat guest customers
@acornforth acornforth mentioned this issue Oct 13, 2021
Merged
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Feb 1, 2022
SirDomin pushed a commit to acornforth/Sylius that referenced this issue May 10, 2022
@acornforth @SirDomin
[Core][Checkout] fixed Sylius#13201
c5dc763 
use canonicalized email for customer lookup on CustomerGuestFormTypes

Caused insert duplicate errors on customer table for repeat guest customers
@SirDomin
Copy link
Contributor

Hey @acornforth I checked out your PR, added behat scenario and it will be merged as soon as its green 💃

@acornforth
Copy link
Contributor Author

@SirDomin Amazing, thanks for that. any idea how long before it's included in a public release?

@SirDomin
Copy link
Contributor

@acornforth i changed branch to 1.10, so probably with new release of 1.10+ versions it will be updated

@markbeazley markbeazley mentioned this issue Oct 10, 2022
Closed
GSadee added a commit that referenced this issue Nov 7, 2022
@GSadee
bug #13202 [Core][Checkout] fixed #13201 (acornforth, SirDomin)
d270ac4 
This PR was merged into the 1.11 branch.

Discussion
----------

use canonicalized email for customer lookup on CustomerGuestFormTypes

Caused insert duplicate errors on customer table for repeat guest customers

| Q               | A
| --------------- | -----
| Branch?         | 1.11
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no?
| Deprecations?   | no
| Related tickets | fixes #13201
| License         | MIT



Commits
-------

f9528ef [Core][Checkout] fixed #13201
d41d762 [Behat] cover scenario with mixed case
GSadee added a commit that referenced this issue Nov 7, 2022
@GSadee
Merge branch '1.11' into 1.12
b8cc8fa 
* 1.11:
  [Behat] cover scenario with mixed case
  [Core][Checkout] fixed #13201
@GSadee GSadee closed this as completed in f9528ef Nov 7, 2022
GSadee added a commit that referenced this issue Nov 7, 2022
@GSadee
Merge branch '1.12' into 1.13
049ac80 
* 1.12:
  [Behat] cover scenario with mixed case
  [Core][Checkout] fixed #13201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acornforth @GSadee @SirDomin
0