[Enchancement] Optimize memory usage by sylius:remove-expired-carts command #14580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvasiloi
reviewed
Nov 25, 2022
src/Sylius/Component/Order/Repository/OrderRepositoryInterface.php
Outdated
Show resolved
Hide resolved
vvasiloi
approved these changes
Nov 25, 2022
GSadee
approved these changes
Dec 8, 2022
Nek-
reviewed
Dec 8, 2022
NoResponseMate
approved these changes
Dec 8, 2022
8b13dab to
9f6fd06
Compare
GSadee
reviewed
Dec 14, 2022
9f6fd06 to
c810050
Compare
GSadee
approved these changes
Dec 14, 2022
|
Thanks, Jakub! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on optimization, not changing the observable behavior, so it doesn't touch command itself, only the service. Moreover, I would like to thank @vvasiloi for helping with this enhancement. The idea of output changes can be implemented (like in Victor's POC #14569), but I believe it should be done later, and in a separate PR.