8000 [Admin] Product Channel Pricings flex display and margin on the last element by PiotrTulacz · Pull Request #18152 · Sylius/Sylius · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Admin] Product Channel Pricings flex display and margin on the last element #18152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[Admin] Product Channel Pricings flex display and margin on the last element #18152

merged 1 commit into from
Jun 17, 2025

Conversation

PiotrTulacz
Copy link
@PiotrTulacz PiotrTulacz commented Jun 11, 2025 •
edited
Loading

image

8000
@PiotrTulacz PiotrTulacz requested review from a team as code owners June 11, 2025 09:42
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Jun 11, 2025
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jun 11, 2025 •
edited
Loading

Walkthrough

CSS utility classes were added and modified in two Twig template files to adjust the layout and spacing of UI elements within the product channel pricing section. No changes were made to the template logic, structure, or exported entities.

Changes

File(s) Change Summary
.../templates/product/form/sections/channel_pricing/info.html.twig Updated inner <div> classes to include flex-column gap-0
.../channel_pricing/info/minimum_price_details.html.twig Added mb-0 class to <p> to remove bottom margin

Poem

A sprinkle of classes, a dash of style,
The pricing forms now wear a smile.
Margins trimmed, columns aligned,
In tidy rows, the prices shine.
🐇✨ CSS hops, the page refined!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 11, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/Sylius/Bundle/AdminBundle/templates/product/form/sections/channel_pricing/info.html.twig (1)

2-2: Verify flex utility classes

Confirm that your CSS framework supports flex-column and gap-0 without an explicit d-flex (e.g., in Bootstrap you’d need d-flex flex-column gap-0 to enable flex layout).

Proposed diff:

-    <div class="alert alert-info flex-column gap-0">
+    <div class="alert alert-info d-flex flex-column gap-0">
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 223d0ce and 46848f1.

📒 Files selected for processing (2)
  • src/Sylius/Bundle/AdminBundle/templates/product/form/sections/channel_pricing/info.html.twig (1 hunks)
  • src/Sylius/Bundle/AdminBundle/templates/product/form/sections/channel_pricing/info/minimum_price_details.html.twig (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Static checks / PHP 8.4, Symfony ^7.2
  • GitHub Check: Static checks / PHP 8.3, Symfony ^7.2
  • GitHub Check: Static checks / PHP 8.2, Symfony ^6.4
🔇 Additional comments (1)
src/Sylius/Bundle/AdminBundle/templates/product/form/sections/channel_pricing/info/minimum_price_details.html.twig (1)

1-1: Approve CSS margin adjustment

The mb-0 utility correctly strips the bottom margin on the paragraph to match the surrounding layout.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 11, 2025 •
edited
Loading

❗ Preview Environment delete from Bunnyshell failed

The Environment cannot be deleted right now. The current operation status is 'starting'.

Check https://github.com/Sylius/Sylius/actions/runs/15701866572 for details.

See: Environment Details

Available commands:

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment

@GSadee GSadee merged commit bd2bbc4 into Sylius:2.1 Jun 17, 2025
105 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiotrTulacz @GSadee
0