feat: Add compatibility for LLVM 18 #1726
Conversation
- Modified build.sh to support version selection via the LLVM_VERSION argument. - Updated C++ source to handle API changes in the LLVM Pass Manager and DominanceFrontier using version guards. - Ensured backward compatibility with the existing LLVM 16 build.
There was a problem hiding this comment.
PR #1258 moved the ExtAPI module load to the beginning of LLVMModuleSet::buildSVFModule() so that analyses see ExtAPI IR immediately. That internal refactor implicitly triggers one call to buildSymbolTable(). The legacy explicit call at the end of the function was left in place, so the symbol table is now built twice. The second build finds totalSymNum == 4 (NullPtr, BlkPtr, BlackHole, ConstantObj) and fails the defensive assertion, crashing every client that links SVF.
- Keeps the first, required pass intact (totalSymNum == 0).
- Turns the second, accidental pass into a no-op, preserving
existing assertions and logic. - Shaves ~5 % off start-up time for large programs because the costly
memory-object walk is no longer repeated.
|
Please resolve the conflict and update. Thanks |
|
Hi 20urc3, [ 83%] Building CXX object svf-llvm/CMakeFiles/SvfLLVM.dir/lib/ObjTypeInference.cpp.o Thanks in advance! |
This pull request introduces compatibility for building SVF with LLVM 18 while maintaining backward compatibility with LLVM 16.
Changes:
build.shscript has been updated to accept anLLVM_VERSION=18argument to switch the LLVM version. It defaults to LLVM 16 if the argument is not provided.#if LLVM_VERSION_MAJOR > 16) to handle API differences in:DominanceFrontierdata structures.How to Test:
./build.sh./build.sh LLVM_VERSION=18