8000 Fix SVG files to have a separating space between the comments and URLs by unique-EJ · Pull Request #1046 · SVG-Edit/svgedit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix SVG files to have a separating space between the comments and URLs #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SVG files to have a separating space between the comments and URLs #1046

wants to merge 2 commits into from

Conversation

unique-EJ
Copy link
@unique-EJ unique-EJ commented Apr 8, 2025 •
edited by sourcery-ai bot
Loading

PR description

Fix SVG files to have separating space between the comments ("Created with SVG-edit - ") and URLs - this lets people use the URLs by double-click without the end comment being added, this was fixed in other files - src/editor/images/hello_world.svg

Checklist

I edited through GitHub and the added changes are a space inside a single comment element... as the tests must be run, would someone help please (to do this).

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

Documentation would be my commit message.

Summary by Sourcery

Bug Fixes:

  • Modify SVG metadata comments to include a space between the 'Created with SVG-edit' text and the URL, allowing easier URL selection by double-clicking

unique-EJ added 2 commits April 8, 2025 21:13
@unique-EJ
Initial commit
cfaa064
@unique-EJ
Fix SVG files ("Created with SVG-edit - "), they have no separating s…
cc3c709 
…pace between the comments and URLs - this lets people use the URLs by double-click without the end comment being added, this was fixed in other files - src/editor/images/hello_world.svg
@sourcery-ai Sourcery AI
Copy link
sourcery-ai bot commented Apr 8, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request adds a space between the comment and the URL in several SVG files. This change allows users to select the URL by double-clicking without inadvertently including the trailing comment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a space between the comment and the URL within the SVG files to allow users to double-click and select the URL without including the comment.
  • Added a space inside the comment element to separate the comment text from the URL.
 src/editor/images/anchor_end.svg
src/editor/images/anchor_middle.svg
src/editor/images/anchor_start.svg
src/editor/images/bold.svg
src/editor/images/italic.svg
src/editor/images/rotate.svg
src/editor/images/text_decoration_linethrough.svg
src/editor/images/text_decoration_overline.svg
src/editor/images/text_decoration_underline.svg
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 8, 2025
View reviewed changes
Copy link
@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @unique-EJ - I've reviewed your changes - here's some feedback:

Overall Comments:

  • This looks like an automated change, consider scripting it to apply to all relevant files.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

8000

@unique-EJ
Copy link
Author
unique-EJ commented Apr 8, 2025 •
edited
Loading

I think there is an issue in packages/svgcanvas/core/svg-exec.js with the space between the comment and the URL, this PR did not fix that.

Please fix the issue, if I open the new image untitled.svg in the SVG-edit Deploy Preview and then edit source (shortcut: U), there is not this change.

jfhenon
jfhenon requested changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator
@jfhenon jfhenon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only fixing existing images. needs to fix as well where this mention is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@jfhenon jfhenon jfhenon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unique-EJ @jfhenon
0