Issue #446: Fixed calls to open without ctx manager #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
+ Coverage 75.71% 75.74% +0.03%
==========================================
Files 20 20
Lines 3125 3134 +9
==========================================
+ Hits 2366 2374 +8
- Misses 759 760 +1 ☔ View full report in Codecov by Sentry. |
|
Just skimmed it and it looks good. Don't mind the build-docs failure, that's probably on me. Edit: Fixed with #474 Gonna look a bit more thoroughly in a bit! |
klieret
requested changes
Jun 2, 2024
inspector/server.py
Outdated
| @@ -277,15 +277,18 @@ def main(data_path, directory, port): | |||
| data = [] | |||
| if data_path is not None: | |||
| if data_path.endswith(".jsonl"): | |||
| data = [json.loads(x) for x in open(data_path).readlines()] | |||
| data = [json.loads(x) for x in Path(data_path).read_text().splitlines(keepend=True)] | |||
There was a problem hiding this comment.
Will merge after this is resolved :)
|
Thanks @milaiwi ! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #446
What does this implement/fix? Explain your changes.
Fixes issues identified by Ruff which advises on proper file handling in Python. Replaces direct file handling methods with safer context handler by using
Path.read_text()andwith open(...) as file:where appropriate.Files