BREAKING CHANGE: messages -> query field in traj #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query attribute now corresponds to the exact input for the LM at the current step. Preciously, the messages attribute for step i was essentially the input for step i+1 in all but rare cases (requeries, etc.). The query attribute now supersedes the messages attribute.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a breaking change by replacing the messages field with a query field to more accurately represent the LM input at the current step. Key changes include:
- Updating the StepOutput and TrajectoryStep models to use a query field.
- Migrating legacy messages in the file viewer to the new query field.
- Updating agent and documentation files to reference the new query field.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sweagent/types.py | Updated models: replaced messages with query |
| sweagent/inspector/fileViewer.js | Migrated legacy messages to query and logged a warning |
| sweagent/agent/agents.py | Adjusted assignment to use query instead of messages |
| docs/usage/trajectories.md | Documented the breaking change from messages to query |
| docs/usage/cli.md | Minor documentation update |
Comments suppressed due to low confidence (1)
sweagent/inspector/fileViewer.js:47
- [nitpick] The variable name 'hasMessages' may be misleading after migrating to 'query'; consider renaming it to 'hasQuery' for better clarity.
const hasMessages = item.query && item.query.length > 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query attribute now corresponds to the exact input for the LM at the current step.
Preciously, the messages attribute for step i was essentially the input for step i+1 in all but rare cases (requeries, etc.). The query attribute now supersedes the messages attribute.