8000 Add base SynapseAction class by thomasyu888 · Pull Request #36 · Sage-Bionetworks/synapsemonitor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add base SynapseAction class #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 27, 2022
Merged

Add base SynapseAction class #36

merged 6 commits into from
Jan 27, 2022

Conversation

thomasyu888
Copy link
Member
@thomasyu888 thomasyu888 commented Jan 21, 2022 •
edited
Loading

Fixes #28
Fixes #34

Start supporting Actions. Email action can be extended by this.

hhunterzinck
hhunterzinck approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator
@hhunterzinck hhunterzinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful outline. Added a comment to outline an idea of increasing generalizability but not sure it's the best approach and may be better for another iteration.

@hhunterzinck hhunterzinck merged commit 2b9dd2b into develop Jan 27, 2022
@hhunterzinck hhunterzinck deleted the add-action branch January 27, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhunterzinck hhunterzinck hhunterzinck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix writing to csv for list Add support to perform an action on modified entities
2 participants
@thomasyu888 @hhunterzinck
2A31
0