8000 Invalid Python code generated for strings containing a single quote · Issue #1310 · Safe-DS/DSL · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Invalid Python code generated for strings containing a single quote #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lars-reimann opened this issue Jan 17, 2025 · 0 comments · Fixed by #1312
Closed

Invalid Python code generated for strings containing a single quote #1310

lars-reimann opened this issue Jan 17, 2025 · 0 comments · Fixed by #1312
Assignees
@lars-reimann

Comments

@lars-reimann
Copy link
Member

Describe the bug

Runtime error if running code that contains a string with single quotes.

// ----- Runtime Error ---------------------------------------------------------
// unterminated triple-quoted string literal (detected at line 31) (classification/gen_titanic, line 30)
// -----------------------------------------------------------------------------

To Reproduce

Code:

pipeline bug {
   out "'";
}

Expected behavior

Code should run without error. The single quote must be escaped.

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann changed the title Invalid Python code generator for strings containing a single quote Invalid Python code generated for strings containing a single quote Jan 17, 2025
@lars-reimann lars-reimann added this to DSL Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Backlog in DSL Jan 17, 2025
@lars-reimann lars-reimann self-assigned this Jan 18, 2025
@lars-reimann lars-reimann moved this from Backlog to In Progress in DSL Jan 18, 2025
@lars-reimann lars-reimann linked a pull request Jan 18, 2025 that will close this issue
fix: escape single quotes in strings in generated Python code #1312
Merged
@lars-reimann lars-reimann mentioned this issue Jan 18, 2025
Merged
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL Jan 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL Jan 18, 2025
lars-reimann pushed a commit that referenced this issue Mar 8, 2025
@semantic-release-bot
chore(release): 0.24.0 [skip ci]
4d6293b 
## [0.24.0](v0.23.0...v0.24.0) (2025-03-08)

### Features

* global attributes ([#1346](#1346)) ([fda30ab](fda30ab))
* new syntax for template strings ([#1311](#1311)) ([88295bc](88295bc))
* optional parameters must be passed by name ([#1307](#1307)) ([674cda8](674cda8)), closes [#1163](#1163)
* type aliases ([#1334](#1334)) ([3d42bb0](3d42bb0)), closes [#1308](#1308)
* update stubs for library version 0.30.0 ([#1345](#1345)) ([42178d1](42178d1))

### Bug Fixes

* allow callable types and union types in type aliases ([#1342](#1342)) ([b9374b5](b9374b5))
* do not suggest references to type alias ([#1343](#1343)) ([c5ef21d](c5ef21d))
* escape single quotes in strings in generated Python code ([#1312](#1312)) ([938f082](938f082)), closes [#1310](#1310)
* handling of aliases of nullable types ([#1344](#1344)) ([99e1006](99e1006))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lars-reimann lars-reimann

Labels
None yet
Projects
DSL
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: escape single quotes in strings in generated Python code Safe-DS/DSL
1 participant
@lars-reimann
0