8000 update megatron example by hanwen-sun · Pull Request #34 · SandAI-org/MagiAttention · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update megatron example #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

update megatron example #34

merged 1 commit into from
May 28, 2025

Conversation

hanwen-sun
Copy link
Collaborator
@hanwen-sun hanwen-sun commented May 28, 2025 •
edited by littsk
Loading
  • Since the alignment task of Megatron is a heavily CPU-bound process, the time is represented as CPU time. To avoid potential misunderstandings, we have removed the time metric.
  • Added essential configuration details.

littsk
littsk approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor
@littsk littsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littsk littsk merged commit 41b4f20 into main May 28, 2025
6 checks passed
@littsk littsk deleted the update_megatron_example branch May 28, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littsk littsk littsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanwen-sun @littsk
0