[IMP] handle context for unlink method #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbentaleb
reviewed
Jan 22, 2025
s6r_compute_tags/models/ir_model.py
Outdated
| @@ -23,11 +23,18 @@ def write(self, vals): | |||
| self._apply_tags(tag_ids) | |||
| return res | |||
|
|
|||
| def unlink(self): | |||
| tag_ids = self.env['model.tag'].search([('model', '=', self._name)]) | |||
There was a problem hiding this comment.
A la place de la condition "if tag_id.compute_on_unlink:" tu rajoute compute_on_link = True dans le domain du search
Et pour self._apply_tags(tag_id) est ce que cela ne va pas générer un bug si on supprime plusieurs lignes en même temps ?
There was a problem hiding this comment.
Ok merci, j'ai fait un commit pour mettre à jour le domaine.
Concernant self._apply_tags(tag_id), la méthode _apply_tags() fait déjà une boucle sur les records. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.