Bump HTTPX #2106
Merged
Bump HTTPX #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 52f713d in 40 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. py/pyproject.toml:19
- Draft comment:
Check that HTTPX 0.28.0 is fully compatible with other dependencies (e.g., FastAPI). - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%
None
2. py/pyproject.toml:7
- Draft comment:
Project version bump to 3.5.9. Ensure changelog reflects this update. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is related to a version bump, which falls under dependency changes. The rules specify not to comment on pure dependency changes or library versions. Additionally, it asks the author to ensure the changelog reflects the update, which is similar to asking for confirmation or ensuring something is done, which is not allowed.
3. py/pyproject.toml:19
- Draft comment:
HTTPX dependency updated to 0.28.0. Verify compatibility and review release notes for any breaking changes. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is about a dependency update, specifically HTTPX to version 0.28.0. It asks the PR author to verify compatibility and review release notes, which falls under the rule of not asking the author to double-check things or ensure behavior. It doesn't provide a specific suggestion or point out a specific issue with the code.
Workflow ID: wflow_5ZmOAG7Q1y8dWQ1G
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 388b1e9 in 2 minutes and 8 seconds
More details
- Looked at
60lines of code in2files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. py/pyproject.toml:19
- Draft comment:
Relaxing the upper bound on httpx might allow future breaking changes. Confirm if this is intended. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to confirm their intention regarding a dependency change. It is not making a specific code suggestion or asking for a test to be written. It is also not pointing out a specific issue or suggesting an improvement. Therefore, it violates the rule against asking the PR author to confirm their intention.
2. py/uv.lock:3155
- Draft comment:
Relaxing the httpx specifier (removing upper bound) may expose issues with untested new versions. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
This comment is about a dependency change, specifically thehttpxspecifier. It suggests that removing the upper bound may expose issues with untested new versions. This falls under the rule of not commenting on dependency changes or library versions that are not recognized. The comment does not provide a specific code suggestion or ask for a specific test to be written, so it should be removed.
3. py/uv.lock:3168
- Draft comment:
pdf2image dependency now marked as extra 'core'. Verify that this optionalization is acceptable. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%
The comment is asking the PR author to verify if marking the pdf2image dependency as optional is acceptable. This falls under asking the author to confirm their intention, which is against the rules. Therefore, this comment should be removed.
4. py/pyproject.toml:21
- Draft comment:
HTTPX: Relaxed version range (from '>=0.28.0,<0.29.0' to '>=0.27.0') removes the upper bound. This may allow unexpected upgrades; consider reintroducing an upper bound. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50%
The comment points out a real inconsistency with the project's dependency management pattern. Most dependencies have upper bounds to prevent unexpected breaking changes. Removing the upper bound could lead to compatibility issues if a major version of httpx is released. The suggestion is specific and actionable.
I might be overvaluing consistency - maybe the author intentionally wants to track httpx's latest version. Also, dependency management is technically against our review rules.
While dependency management is generally out of scope, this is a clear pattern break that could cause real issues, and the fix is simple and specific.
Keep the comment as it identifies a specific issue with a clear fix that matches the project's dependency management pattern.
5. py/uv.lock:3029
- Draft comment:
PDF2Image dependency has been relocated from the main dependencies to the 'core' extra. Confirm that this dependency should now be optional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
This is a dependency management change. Per the rules, we should not comment on dependency changes or library versions. Additionally, the comment is asking for confirmation/verification, which is explicitly called out as not useful in the rules. The author clearly intended to make this change since they explicitly moved the dependency.
Perhaps this is a critical dependency that could break core functionality if made optional? Maybe we should verify the impact?
No - per the rules, we should trust that dependency changes were made intentionally and not comment on them. The author knows best about their dependency structure.
Delete this comment as it violates multiple rules: no commenting on dependency changes, and no asking for confirmations/verifications.
6. py/uv.lock:3154
- Draft comment:
HTTPX in requires-dist now lacks an upper bound (changed from '>=0.27.0,<0.28.0' to '>=0.27.0'). Ensure this broader range is intentional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50%
The rules explicitly state "Do NOT comment on dependency changes, library versions that you don't recognize, or anything else related to dependencies." Additionally, the comment asks to "ensure" something, which is also explicitly forbidden by the rules. This is a clear case where the comment should be removed.
The version change could potentially introduce breaking changes that might affect the project's stability.
While dependency version changes can be important, the rules clearly state we should not comment on them. We must trust that the author has considered the implications of this change.
Delete this comment as it violates two rules: commenting on dependency changes and asking the author to "ensure" something.
Workflow ID: wflow_rT0fR0ykuojmh7Lx
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
httpxdependency version constraint and adjustpdf2imagemarker inuv.lock, increment project version to 3.5.9.httpxversion constraint inpyproject.tomlanduv.lockto>=0.27.0(removes upper limit).pdf2imagedependency inuv.lockto be included only with 'core' extra.3.5.8to3.5.9inpyproject.tomlanduv.lock.This description was created by
for 388b1e9. It will automatically update as commits are pushed.