Improvements to Flinn-Engdahl region names #135
Conversation
|
I am must admit that I do not know why and how abbreviations made it into the names because Wikipedia does not use them. Maybe @jsaul can remember how this has happened. I am happy to merge your changes, thanks a lot. |
|
The names were inherited from old Fortran codes and at some point turned into a more readable form as the original names where all upper case... The abbreviations were probably due to tight space constraints in the Fortran codes. That said I appreciate the changes! |
|
ObsPy actually maintains the original list of names here: https://github.com/obspy/obspy/blob/master/obspy/geodetics/data/names.asc?plain=1 |
|
I personally would prefer Wikipedia as source for the names but that is just my opinion. Obspy is still using the very old version with IRIAN JAYA, so they might have taken that from the same source as we did 18 years ago ;) In the end I do not want to offend anyone with old region names. Even putting only the FE region ID would be sufficient and anyone can grep her own translation. |
|
@gempa-jabe Sorry for the misunderstanding, I was not proposing to go back to the original names, only referring to the old list for "historical reasons". 😃 And yes I would also strictly follow Wikipedia, but there we have the issue with https://en.wikipedia.org/wiki/Turkey |
|
Don't worry, I just wanted to add my opinion w.r.t. this PR and I understood your comment as how you intended it. |
The important thing here is that Senegal is spelled "Sengal", which is incorrect.
Additionally, since I could find no other French translation elsewhere (https://en.wikipedia.org/wiki/Flinn-Engdahl_regionalization only has translations to Spanish and German the same languages other than English supported by https://github.com/jsaul/flinnengdahl), I did my own translation to French. In the process, I found that the (inconsistent!) use of abbreviations really got in the way, so here I've also eliminate 8000 d the abbreviations.
If there is a reason to keep the abbreviations, let me know and I'll initiate a pull request that only corrects the spelling of Senegal.