8000 Modal component by lucasreichert3 · Pull Request #32 · SeniorSA/tecnologia-webcomponents · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Modal component #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 30, 2021
Merged

Modal component #32

merged 11 commits into from
Mar 30, 2021

Conversation

lucasreichert3
Copy link
Contributor

No description provided.

@tiagoboeing tiagoboeing self-assigned this Mar 26, 2021
@tiagoboeing tiagoboeing added this to the first components milestone Mar 26, 2021
tiagoboeing
tiagoboeing reviewed Mar 26, 2021
View reviewed changes
tiagoboeing
tiagoboeing reviewed Mar 26, 2021
View reviewed changes
tiagoboeing
tiagoboeing suggested changes Mar 26, 2021
View reviewed changes
tiagoboeing
tiagoboeing reviewed Mar 29, 2021
View reviewed changes
@lucasreichert3 @tiagoboeing
Update CHANGELOG.md
929faab 
Co-authored-by: Tiago Boeing <contato@tiagoboeing.com>
tiagoboeing
tiagoboeing reviewed Mar 29, 2021
View reviewed changes
tiagoboeing
tiagoboeing suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor
@tiagoboeing tiagoboeing left a comment •
edited by lucasreichert3
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Create a responsive prop to auto-adjust using media queries
  • Change blockScroll prop to something like blockBodyScroll, blockParentScroll...

lucasreichert3 and others added 3 commits March 29, 2021 11:10
tiagoboeing
tiagoboeing reviewed Mar 29, 2021
View reviewed changes
tiagoboeing
tiagoboeing reviewed Mar 29, 2021
View reviewed changes
tiagoboeing
tiagoboeing reviewed Mar 29, 2021
View reviewed changes
tiagoboeing
tiagoboeing suggested changes Mar 29, 2021
View reviewed changes
Copy link
Contributor
@tiagoboeing tiagoboeing left a comment •
edited by lucasreichert3
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Increase clickable area from close button
    image
  • Set a max-height for modal content using overflow:
    image

tiagoboeing
tiagoboeing approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor
@tiagoboeing tiagoboeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoboeing tiagoboeing merged commit 82477c0 into develop Mar 30, 2021
@tiagoboeing tiagoboeing deleted the feature/modal branch March 30, 2021 13:08
lucasreichert3 added a commit that referenced this pull request Mar 30, 2021
@lucasreichert3
Generate 0.5.0 (#38)
7b197df 
* Modal component (#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoboeing tiagoboeing tiagoboeing approved these changes

Assignees

@tiagoboeing tiagoboeing

Labels
components
Projects
None yet
Milestone
first components
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasreichert3 @tiagoboeing
0