System test robustness #1189
Merged
System test robustness #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
This causes flakiness when we're navigating pages because Capybara goes back to the browser to check for the visibility of the node, which doesn't exist anymore. Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
A lot of flakiness seems to come from the fact that the errors changed
for invalid elements:
{"code":-32000,"message":"Node with given id does not belong to the document"}
This is a hack that handles all unknown errors as invalid element
errors.
Co-authored-by: Adrianna Chang <adrianna.chang@shopify.com>
Closed
|
Actually the commit that disables checking for the visibility of elements might not be a good idea. We don't use invisible elements at all so I'll let that slip in, but for reference for the future, if this cause an issue, feel free to revert 2105366. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We paired with @adrianna-chang-shopify on improving the stability of system tests.
We found a few issues related the code, but a lot of it is related to changes to Chrome 134 it seems:
SeleniumHQ/selenium#15401
teamcapybara/capybara#2800
Last commit is a hack to make sure Capybara retries when the element is no longer on the page because it's something it's always done, and now it just considers them unknown errors. This will need to be reverted once things have settled.