Translate T.cast and T.must into RBS comments
#714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e801ba to
23a9d85
Compare
paracycle
reviewed
Mar 18, 2025
lib/spoom/cli/srb/assertions.rb
Outdated
| @@ -11,6 +11,9 @@ class Assertions < Thor | |||
| desc "translate", "Translate type assertions from/to RBI and RBS" | |||
| option :from, type: :string, aliases: :f, desc: "From format", enum: ["rbi"], default: "rbi" | |||
| option :to, type: :string, aliases: :t, desc: "To format", enum: ["rbs"], default: "rbs" | |||
| option :let, type: :boolean, desc: "Translate `T.let` to `nil #: String?`", default: true | |||
There was a problem hiding this comment.
The inclusion of nil here looks out of place to me:
Suggested change
| option :let, type: :boolean, desc: "Translate `T.let` to `nil #: String?`", default: true | |
| option :let, type: :boolean, desc: "Translate `T.let` to `#: String`", default: true |
I think a better message would be:
Suggested change
| option :let, type: :boolean, desc: "Translate `T.let` to `nil #: String?`", default: true | |
| option :let, type: :boolean, desc: "Translate `T.let(x, String)` to `x #: String?`", default: true |
lib/spoom/cli/srb/assertions.rb
Outdated
Comment on lines
15
to
16
| option :cast, type: :boolean, desc: "Translate `T.cast` to `# as String`", default: true | ||
| option :must, type: :boolean, desc: "Translate `T.must` to `# as not nil`", default: true |
There was a problem hiding this comment.
If my suggestion above is accepted, then better messages would be:
Suggested change
| option :cast, type: :boolean, desc: "Translate `T.cast` to `# as String`", default: true | |
| option :must, type: :boolean, desc: "Translate `T.must` to `# as not nil`", default: true | |
| option :cast, type: :boolean, desc: "Translate `T.cast(x, String)` to `x # as String`", default: true | |
| option :must, type: :boolean, desc: "Translate `T.must(x)` to `x # as !nil`", default: true |
lib/spoom/cli/srb/assertions.rb
Outdated
Comment on lines
15
to
16
| option :cast, type: :boolean, desc: "Translate `T.cast` to `# as String`", default: true | ||
| option :must, type: :boolean, desc: "Translate `T.must` to `# as not nil`", default: true |
There was a problem hiding this comment.
Suggested change
| option :cast, type: :boolean, desc: "Translate `T.cast` to `# as String`", default: true | |
| option :must, type: :boolean, desc: "Translate `T.must` to `# as not nil`", default: true | |
| option :cast, type: :boolean, desc: "Translate `T.cast` to `# as String`", default: true | |
| option :must, type: :boolean, desc: "Translate `T.must` to `# as !nil`", default: true |
lib/spoom/sorbet/assertions.rb
Outdated
| @annotation_methods << :let if let | ||
| @annotation_methods << :cast if cast | ||
| @annotation_methods << :must if must | ||
|
|
There was a problem hiding this comment.
It might be a good idea to do:
Suggested change
| @annotation_methods.freeze |
here.
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
23a9d85 to
176a625
Compare
|
Major rewrite on top of #734. |
176a625 to
b66e878
Compare
st0012
reviewed
May 20, 2025
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
b66e878 to
8d9b887
Compare
st0012
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will now allow to translate
T.mustinto RBS comments so this:becomes this:
And
T.mustso this:becomes this: