8000 Translate all `T.let` to RBS inline comments supported by Sorbet by Morriar · Pull Request #715 · Shopify/spoom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Translate all T.let to RBS inline comments supported by Sorbet #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025

Conversation

Morriar
Copy link
Collaborator
@Morriar Morriar commented Mar 19, 2025

Using spoom srb assertions translate all assertions like:

x = T.let(foo, String)

can be translated to:

x = foo #: String

and understood by Sorbet with the option --enable-experimental-rbs-assertions.

@Morriar Morriar added the chore Chore task label Mar 19, 2025
@Morriar Morriar self-assigned this Mar 19, 2025
@Morriar Morriar requested a review from a team as a code owner March 19, 2025 22:15
Morriar added 2 commits March 27, 2025 13:50
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Using `spoom srb assertions translate`.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar merged commit 38771f4 into main Mar 31, 2025
8 checks passed
@Morriar Morriar deleted the at-rbs-let branch March 31, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0