Handle upcoming prism deprecations #431
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Shopify#388, prism is used to parse ruby code. It uses `Prism::Translation::Parser` which always parses code as Ruby 3.4. It's a behavior change, previously it parserd as the currently running ruby. I don't know enough about packwerk to know if that makes issues. Anyways, I plan to deprecate `Prism::Translation::Parser` because I've seen it used as a replacement for `Parser::CurrentRuby` (like here), which it isn't.
prism requires its own builder class in order to emit ast for versions that the parser gem doesn't support. The next prism version will warn when a incorrect builder class is used, it wasn't previously enforced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Avoid prism deprecation warnings:
Prism::Translation::Parserruby/prism#3524What approach did you choose and why?
Use the non-deprecated classes.
Parser34is available since 0.24.0 and can be used without concern. The builder is somewhat new, so I usedefined?to check it and left a note for when it can be removed.What should reviewers focus on?
I left more context in the two commit messages.
Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist