8000 Fix plain text prompts configuration by palkan · Pull Request #60 · Shopify/roast · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix plain text prompts configuration #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix plain text prompts configuration #60

wants to merge 1 commit into from
+17 −1

Conversation

palkan
Copy link
Contributor
@palkan palkan commented May 20, 2025

This fixes the bug with the model not being passed to the prompt step (so, the default anthropic:claude-sonnet-3.7 is always used by text steps).

The auto_loop: false seems unnecessary since we set auto_loop: false in the PromptStep explicitly.

I decided to use the same #step_setup method so we can do all the configuration tweaks uniformly.

@obie
Copy link
Contributor
obie commented May 21, 2025

Also needs test coverage.

@palkan palkan force-pushed the fix/prompt-steps-params branch from 55044a5 to ab4c4cc Compare May 21, 2025 18:22
@palkan
- use setup_step to setup Prompt steps
2b3f7c8 
This fixes the bug with the model not being passed to the prompt step
@palkan palkan force-pushed the fix/prompt-steps-params branch from ab4c4cc to 2b3f7c8 Compare May 21, 2025 18:29
@palkan
Copy link
Contributor Author
palkan commented May 21, 2025

Added a test (though I don't really like it—this expect/mock style is too brittle, especially when we need to verify call args; but we don't have any other testing infra yet).

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palkan @obie
0