Add pause flag #68
Merged
Add pause flag #68
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonallured
commented
May 21, 2025
| when String | ||
| execute_string_step(step) | ||
| execute_string_step(workflow_step) | ||
| Kernel.binding.irb if workflow.pause_step_name == step |
There was a problem hiding this comment.
Hey @nfgrep this used to be extracted to a separate method but....then the context wasn't at this code location and the step local wasn't in scope. Move this back and then was able to wrangle Minitest as seen in that file below.
1f8ce9a to
cc660bc
Compare
parruda
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
pauseflag that takes a step name. When that step name comes up it triggers abinding.irbsession. Fun fact prior to this PR that location had a local variable name calledstep- can you guess what happened when attempting to reference that var? That's right it.....stepped to the next line. 😝So in order to mitigate that I also reworked the locals in that method so that there were no collisions.
Paired on this with @nfgrep 🍐
Closes #16