8000 Remove mentions of Preact in React package by alxclark · Pull Request #374 · Shopify/remote-dom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove mentions of Preact in React package #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

Remove mentions of Preact in React package #374

merged 1 commit into from
Jul 3, 2024

Conversation

alxclark
Copy link
Contributor
@alxclark alxclark commented Jun 23, 2024 •
edited
Loading

It looks like some comments were copied from the Preact implementation and should mention React instead.

I also noticed that Preact is listed as a dev dep in @remote-dom/react but isn't used:

remote-dom/packages/react/package.json

Line 82 in daf2007

"preact": "^10.19.0",

Happy to fix this as well.

I'm also not sure if this warrants a changeset, let me know.

@alxclark alxclark requested a review from lemonmade June 23, 2024 04:25
@github-actions GitHub Actions
Copy link
Contributor

We detected some changes in public packages, and there are no updates in the .changeset directory.
If the changes are user-facing and should cause a version bump, run pnpm changeset to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to repo configuration, examples, or documentation, you do not need to add a changeset.

lemonmade
lemonmade approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member
@lemonmade lemonmade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex! Agreed that a changeset is not needed here, we will just publish the updated documentation as part of the next version that gets released.

@lemonmade lemonmade merged commit 7a69239 into main Jul 3, 2024
5 checks passed
@lemonmade lemonmade deleted the alx/react-preact-typos branch July 3, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonmade lemonmade lemonmade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxclark @lemonmade
0