Support for SVGs and images in theme-graph #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
8000
Learn more about bidirectional Unicode characters
aswamy
commented
Jun 18, 2025
| LiquidFilter: (node, ancestors) => { | ||
| if (node.name === 'asset_url') { | ||
| if (['asset_url', 'asset_img_url', 'inline_asset_content'].includes(node.name)) { |
There was a problem hiding this comment.
These are the only filters i knew that reference images or svgs that are in assets folder, let me know if i missed anything
| @@ -136,13 +159,29 @@ export const enum LiquidModuleKind { | |||
| Template = 'template', | |||
| } | |||
|
|
|||
| export const SUPPORTED_ASSET_IMAGE_EXTENSIONS = ['jpg', 'jpeg', 'png', 'gif', 'webp', 'heic']; | |||
There was a problem hiding this comment.
Im not sure if we support other image assets in the asset folder, but could add more if anyone knows more
There was a problem hiding this comment.
Would we ever want .ico?
EvilGenius13
approved these changes
Jun 18, 2025
charlespwd
approved these changes
Jun 19, 2025
Comment on lines
+28
to
+33
| | JSONSourceCode | ||
| | LiquidSourceCode | ||
| | JsSourceCode | ||
| | CssSourceCode | ||
| | ImageSourceCode | ||
| | SvgSourceCode |
There was a problem hiding this comment.
Should probably type alias this union :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Fixes #981
Tophat
Before you deploy
changeset