Cap contract formation at require height #1897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a guard in formContract to ensure v1 contracts are never formed at or beyond the v2 require height.
- Introduces logic to cap
endHeighttoHardforkV2.RequireHeight - 1 - Adds commentary describing the cap behavior
Comments suppressed due to low confidence (2)
bus/bus.go:648
- [nitpick] Consider renaming
v2ReqHeighttov2RequireHeightfor improved clarity.
v2ReqHeight := b.cm.TipState().Network.HardforkV2.RequireHeight
bus/bus.go:646
- Add unit tests to verify that
endHeightis correctly capped toRequireHeight - 1when it meets or exceeds the v2 require height.
// cap v1 formations to the v2 require height since the host won't allow us to
5e0c571 to
4cef176
Compare
4cef176 to
ec1ae55
Compare
n8maninger
approved these changes
May 29, 2025
peterjan
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little check we already have for renewals but not formations. This allows users with contract periods that cover more than a window between allow height and require height to continue to form v1 contracts.